You know we're in the unfortunate situation of having two forks implementing c2s server. I'm currently tending towards the @superfeedr branch, just because Julien had me look into it earlier. Remember: release early, release often, and talk. Refusing contributions really gives me a bad conscience.

Nevertheless I want to give you some feedback. It could be nitpicking, but I don't want to hand your pull request down without technical reasons.

• Your commits are huge and have non-descriptive messages. git provides nice means of representing development in a comprehensible way. (Julien's aren't much better: b9b6eba)
• Roster isn't spelled Roaster
• IqExtender looks useful. What is it for? :-) On the other hand, I don't like custom code performing magic for just specific parts.
• Your tests are appreciated! Maybe we could merge them independently?
• mechanisms belong to SASL and I'd like to have that kind of distinguishably separate from the XMPP stuff. We shall distinguish between client and server cases here too.
• Specific queries like roster requests should not be handled by the library but the full-fledged XMPP server that will use the code one day.
• Julien has implemented SASL PLAINTEXT for the server side as well. The other (digest) mechanisms that don't pass passwords in clear text are more interesting though.
• TLS support is also quite important. We're having trouble with that.
• XmppServer is named a bit unfortunate when it is c2s-specific. I think even the s2s-specific Router I added before is a misnomer.
• Your code looks good, though style differs from the rest. I know that's a highly opinionated topic: I myself still have to convince emacs not to use tabs.
• Would you mind explaining Logitech Connect? We've already got support for Facebook authentication, so I totally don't oppose such things.

Hi astro,

In my design, I want to allow anyone to extend code easily. I am not a believer on comments, but a strong believer on TDD. As a result, I got my code fullly coverage, yet might not have a good description. :)

Let me address your comments.

1. I will add more descriptive message
2. Rename to Roster should be a easy changes
3. The intention of IqExtender is to allow other developers to add more extension for IQ, for example Roaster, IQ Query Action Protocol, and etc
4. I am happy you like the tests. I can migrate the tests to you once you decide which c2s branch you want to merge into your code.
5. My design of mechanisms also have your same intention mind. I would like to allow the C2S server to only support SASL mechanisms they want. You can write a Digest SASL mechanism as well.
6. Roster can be removed as long as no iq extension is specified in constructor of XmppServer (C2SServer after change)
7. PLAINTEXT or Digest mechanism should be support by the library for marshalling purpose, the actual validation should be extensible by the mechansim, which can be a web service/database query.
8. I look into the Connection classes, I thought TLS has already support. I need to test it
9. I will rename it to C2SServer?
10. You like the code in tabs or spaces? I can follow your standard.
11. Logitech Connect is a iq extension that I want to work with. I don't think it should be part of the node-xmpp.

Hey Hpychan, I think our c2s branch is now functional and works fine. However, one thing that it lacks is tests. I was hoping that maybe we could re-use the ones you used for your own branch.
I am not very familiar with vowsjs, but maybe you could point me to where I can start? Thanks!

Julien's branch has been merged now. Please help me maintaining it. :-)